From 791a1d79a97fdc3829408bea2af6b38f2837adf9 Mon Sep 17 00:00:00 2001 From: Andreas Eversberg Date: Thu, 24 Nov 2022 21:15:47 +0100 Subject: [PATCH] osmo-cc: Set session to NULL, if no codec matches Applications will crash, due to use-after-free bug, if this is not done. --- src/libosmocc/helper.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/libosmocc/helper.c b/src/libosmocc/helper.c index 4eeee92..7700174 100644 --- a/src/libosmocc/helper.c +++ b/src/libosmocc/helper.c @@ -125,6 +125,7 @@ const char *osmo_cc_helper_audio_accept(osmo_cc_session_config_t *conf, void *pr if (!selected_codec) { PDEBUG(DCC, DEBUG_ERROR, "No codec found in setup message that we support.\n"); osmo_cc_free_session(*session_p); + *session_p = NULL; return NULL; } osmo_cc_session_accept_codec(selected_codec, codecs[selected_codec_i].encoder, codecs[selected_codec_i].decoder); @@ -138,6 +139,7 @@ const char *osmo_cc_helper_audio_accept(osmo_cc_session_config_t *conf, void *pr accept_sdp = osmo_cc_session_send_answer(*session_p); if (!accept_sdp) { osmo_cc_free_session(*session_p); + *session_p = NULL; return NULL; }