Fix review comments

This commit is contained in:
Pierre Ståhl
2020-10-14 12:01:24 +02:00
parent 15a79ec690
commit baad2cfab0
2 changed files with 5 additions and 3 deletions

View File

@@ -34,6 +34,8 @@ localtuya:
friendly_name: Device Light friendly_name: Device Light
id: 4 id: 4
brightness: 20 brightness: 20
brightness_lower: 29 # Optional
brightness_upper: 1000 # Optional
color_temp: 21 color_temp: 21
- platform: sensor - platform: sensor

View File

@@ -35,7 +35,7 @@ def map_range(value, from_lower, from_upper, to_lower, to_upper):
mapped = (value - from_lower) * (to_upper - to_lower) / ( mapped = (value - from_lower) * (to_upper - to_lower) / (
from_upper - from_lower from_upper - from_lower
) + to_lower ) + to_lower
return int(min(max(mapped, to_lower), to_upper)) return round(min(max(mapped, to_lower), to_upper))
def flow_schema(dps): def flow_schema(dps):
@@ -112,7 +112,7 @@ class LocaltuyaLight(LocalTuyaEntity, LightEntity):
async def async_turn_on(self, **kwargs): async def async_turn_on(self, **kwargs):
"""Turn on or control the light.""" """Turn on or control the light."""
self._device.set_dp(True, self._dp_id) await self._device.set_dp(True, self._dp_id)
features = self.supported_features features = self.supported_features
if ATTR_BRIGHTNESS in kwargs and (features & SUPPORT_BRIGHTNESS): if ATTR_BRIGHTNESS in kwargs and (features & SUPPORT_BRIGHTNESS):
@@ -123,7 +123,7 @@ class LocaltuyaLight(LocalTuyaEntity, LightEntity):
self._lower_brightness, self._lower_brightness,
self._upper_brightness, self._upper_brightness,
) )
self._device.set_dp(brightness, self._config.get(CONF_BRIGHTNESS)) await self._device.set_dp(brightness, self._config.get(CONF_BRIGHTNESS))
if ATTR_HS_COLOR in kwargs: if ATTR_HS_COLOR in kwargs:
raise ValueError(" TODO implement RGB from HS") raise ValueError(" TODO implement RGB from HS")